Skip to content

win32: modernize pthread_cond_*() shims - #80

Closed
dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:mingw-modernize-pthread_cond_t
Closed

dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:mingw-modernize-pthread_cond_t

Conversation

@dscho

@dscho dscho commented Nov 13, 2018 •

Copy link
Copy Markdown
Member

And yet another patch from Git for Windows' cache of treasures.

It was challenging to emulate the functions related to pthread_cond_t as long as we tried to maintain support for Windows XP, which has nothing close to that feature. Now that we require Windows Vista or later, we can make use of the very nice functions associated with the CONDITION_VARIABLE data type.

Look at how much code this deletes, and how little it introduces. This is a maintainer's dream.

The Win32 CONDITION_VARIABLE has better performance and is easier to
maintain, as the code is a lot shorter now (the semantics of the
CONDITION_VARIABLE matches the pthread_cond_t very well).

Note: CONDITION_VARIABLE is not available in Windows XP and below,
but the declared minimal Windows version required to build and run
Git for Windows is Windows Vista (which is also beyond its
end-of-life, but for less long than Windows XP), so that's okay.

Signed-off-by: Loo Rong Jie <loorongjie@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho mentioned this pull request Nov 13, 2018
35 tasks done
@dscho

dscho commented Nov 13, 2018

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Nov 13, 2018

Copy link
Copy Markdown

Submitted as pull.80.git.gitgitgadget@gmail.com

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This branch is now known as lj/mingw-pthread-cond.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This patch series was integrated into pu via git@06a2d24.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This patch series was integrated into next via git@06a2d24.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This patch series was integrated into master via git@06a2d24.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

This patch series was integrated into maint via git@06a2d24.

@gitgitgadget

gitgitgadget Bot commented Dec 15, 2018

Copy link
Copy Markdown

Closed via 06a2d24.

@dscho
dscho deleted the mingw-modernize-pthread_cond_t branch December 15, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants